feat(Clusters): redesign table #2495
Merged
+164
−171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
redesign-clusters
branch
from
aa1515f to
e2ac829
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR redesigns the clusters table view by updating column definitions, internationalized strings, and UI components.
- Major i18n updates and label/text changes in the clusters table
- Adjustments to column definitions including removal of deprecated columns and adding new ones (STATUS and SERVICE)
- Introduction of a custom progress bar component and updated search component
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/containers/Clusters/i18n/en.json | Updated i18n strings and labels for the clusters table |
| src/containers/Clusters/constants.ts | Removed deprecated columns and updated column titles |
| src/containers/Clusters/columns.tsx | Revised column setup, added new columns, and introduced a progress bar |
| src/containers/Clusters/Clusters.tsx | Updated rendering of the table title, search input, and error display |
| src/containers/Clusters/Clusters.scss | Adjusted styling for new widths and added new CSS variables |
| src/components/Search/Search.tsx | Enhanced input props handling by spreading additional properties |
Comments suppressed due to low confidence (1)
src/containers/Clusters/columns.tsx:232
- The 'SERVICE' column does not have a render method defined, which might lead to an empty column in the table. Consider implementing a render function to ensure that the column displays the expected content.
name: COLUMNS_NAMES.SERVICE,
astandrik
reviewed
Jun 30, 2025
astandrik
previously approved these changes
Jun 30, 2025
artemmufazalov
commented
Jun 30, 2025
| {clusters?.length} | ||
| </Text> | ||
| </Flex> | ||
| <Text variant="header-1">{uiFactory.clustersPageTitle ?? i18n('page_title')}</Text> |
There was a problem hiding this comment.
I made possible to set title in uiFactory to prevent YDB EM name in open-source version
astandrik
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2334
Stands: https://nda.ya.ru/t/HABYg_Bv7FpMCr
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️3
⏭️ Skipped Tests (3)
Bundle Size: ✅
Current: 84.00 MB | Main: 84.01 MB
Diff: 4.29 KB (-0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information